CurtHagenlocher commented on code in PR #2965:
URL: https://github.com/apache/arrow-adbc/pull/2965#discussion_r2146209223
##########
csharp/test/Apache.Arrow.Adbc.Tests/ColumnNetTypeArrowTypeValue.cs:
##########
@@ -32,12 +41,38 @@ public ColumnNetTypeArrowTypeValue(string name, Type
expectedNetType, Type expec
this.ExpectedValue = expectedValue;
}
+ /// <summary>
+ /// Instantiates <see cref="ColumnNetTypeArrowTypeValue"/>.
+ /// </summary>
+ /// <param name="name">The column name</param>
+ /// <param name="expectedNetType">The expected .NET type</param>
+ /// <param name="expectedArrowArrayType">The expected Arrow
type</param>
+ /// <param name="expectedValue">The expected value</param>
+ /// <param name="isValid">A function that can be run to compare
values</param>
+ /// <exception cref="ArgumentNullException"></exception>
+ public ColumnNetTypeArrowTypeValue(string name, Type expectedNetType,
Type expectedArrowArrayType, bool expectedValue, Func<object?, bool> isValid)
+ {
+ this.Name = name;
+ this.ExpectedNetType = expectedNetType;
+ this.ExpectedArrowArrayType = expectedArrowArrayType;
+ this.ExpectedValue = expectedValue;
+
+ _isValid = isValid ?? throw new
ArgumentNullException(nameof(isValid));
+ }
+
public string Name { get; set; }
public Type ExpectedNetType { get; set; }
public Type ExpectedArrowArrayType { get; set; }
public object? ExpectedValue { get; set; }
+
+ public bool IsCalcuatedResult => _isValid != null;
Review Comment:
Typo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
