lidavidm commented on code in PR #2965:
URL: https://github.com/apache/arrow-adbc/pull/2965#discussion_r2147453833
##########
go/adbc/driver/snowflake/driver_test.go:
##########
@@ -1724,6 +1724,118 @@ func (suite *SnowflakeTests) TestBooleanType() {
}
}
+func (suite *SnowflakeTests) TestTimestampPrecisionJson() {
+ opts := suite.Quirks.DatabaseOptions()
+ opts[driver.OptionMaxTimestampPrecision] = "microseconds"
+
+ db, err := suite.driver.NewDatabase(opts)
+ suite.NoError(err)
+ defer validation.CheckedClose(suite.T(), db)
+ cnxn, err := db.Open(suite.ctx)
+ suite.NoError(err)
+ defer validation.CheckedClose(suite.T(), cnxn)
+ stmt, _ := cnxn.NewStatement()
+
+ id := uuid.New()
+ tempTable := "pk_" + strings.ReplaceAll(id.String(), "-", "")
+
+ query := fmt.Sprintf(`CREATE OR REPLACE TABLE %s.%s.%s (
+ id INT PRIMARY KEY,
+ name STRING);`, suite.Quirks.catalogName, suite.Quirks.schemaName,
tempTable)
+
+ suite.Require().NoError(stmt.SetSqlQuery(query))
+ _, err = stmt.ExecuteUpdate(suite.ctx)
+ suite.Require().NoError(err)
+
+ query = fmt.Sprintf("SHOW PRIMARY KEYS IN TABLE %s.%s.%s",
suite.Quirks.catalogName, suite.Quirks.schemaName, tempTable)
+ stmt, _ = cnxn.NewStatement()
+ suite.Require().NoError(stmt.SetSqlQuery(query))
+ rdr, _, err := stmt.ExecuteQuery(suite.ctx)
+ defer rdr.Release()
+ suite.Require().NoError(err)
+
+ suite.True(rdr.Next())
+ rec := rdr.Record()
+
+ result := validateRecord(
+ rec,
+ suite.Quirks.catalogName,
+ suite.Quirks.schemaName,
+ tempTable,
+ )
+
+ suite.True(result, "Expected primary key record not found")
+
+ query = fmt.Sprintf("DROP TABLE %s.%s.%s", suite.Quirks.catalogName,
suite.Quirks.schemaName, tempTable)
+ stmt, _ = cnxn.NewStatement()
+ suite.Require().NoError(stmt.SetSqlQuery(query))
+ _, err = stmt.ExecuteUpdate(suite.ctx)
+ defer rdr.Release()
+ suite.Require().NoError(err)
+}
+
+func validateRecord(
+ rec arrow.Record,
+ catalogName string,
+ schemaName string,
+ tableName string,
+) bool {
+ // Get column indexes
+ getColIdx := func(name string) int {
+ for i := 0; i < int(rec.NumCols()); i++ {
+ if rec.ColumnName(i) == name {
+ return i
+ }
+ }
+ return -1
+ }
+
+ // Expected column names
+ dbIdx := getColIdx("database_name")
+ schemaIdx := getColIdx("schema_name")
+ tableIdx := getColIdx("table_name")
+ colIdx := getColIdx("column_name")
+ seqIdx := getColIdx("key_sequence")
+ createdIdx := getColIdx("created_on")
+
+ if dbIdx == -1 || schemaIdx == -1 || tableIdx == -1 || colIdx == -1 ||
seqIdx == -1 || createdIdx == -1 {
+ fmt.Println("Missing expected columns")
+ return false
+ }
+
+ numRows := int(rec.NumRows())
+ for i := 0; i < numRows; i++ {
+ dbName := rec.Column(dbIdx).(*array.String).Value(i)
+ schema := rec.Column(schemaIdx).(*array.String).Value(i)
+ tbl := rec.Column(tableIdx).(*array.String).Value(i)
+ column := rec.Column(colIdx).(*array.String).Value(i)
+ keySeq := rec.Column(seqIdx).(*array.Int64).Value(i)
+
+ // Created_on should be a timestamp array
+ createdCol := rec.Column(createdIdx).(*array.Timestamp)
+ created := time.Unix(0,
int64(createdCol.Value(i))*int64(time.Microsecond)).UTC()
+
+ // Perform checks
+ if strings.EqualFold(dbName, catalogName) &&
+ strings.EqualFold(schema, schemaName) &&
+ strings.EqualFold(tbl, tableName) &&
+ strings.EqualFold(column, "id") &&
+ keySeq == 1 {
+
+ now := time.Now().UTC()
+ diff := now.Sub(created)
+ if diff < 0 {
+ diff = -diff
+ }
+ if diff <= 2*time.Minute {
+ return true
+ }
+ }
+ }
+
+ return false
Review Comment:
Is it intended for this loop to stop once it finds one matching row?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
