thisisnic commented on code in PR #46720:
URL: https://github.com/apache/arrow/pull/46720#discussion_r2149645686
##########
r/tests/testthat/test-data-type.R:
##########
@@ -497,10 +496,6 @@ test_that("decimal type and validation", {
expect_error(decimal128(4, NA), "`scale` must be an integer")
expect_error(decimal128(3:4, NA), "`precision` must have size 1. not size 2")
expect_error(decimal128(4, 2:3), "`scale` must have size 1. not size 2")
- # TODO remove precision range tests below once functionality is tested in
C++ (ARROW-15162)
- expect_error(decimal128(0, 2), "Invalid: Decimal precision out of range [1,
38]: 0", fixed = TRUE)
- expect_error(decimal128(100, 2), "Invalid: Decimal precision out of range
[1, 38]: 100", fixed = TRUE)
-
Review Comment:
There were tests added
[here](https://github.com/apache/arrow/pull/43957/files#diff-1bdade8037e08dc30047ce7d8218c63e39f908d416be1b2b1c586dcd410dfc1aR2226-R2240)
so we can get rid of our own tests for this, but the `decimal()` C++ function
was deprecated in favour of `smallest_decimal()` so I'll need to swap that out
too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
