WillAyd commented on code in PR #46830:
URL: https://github.com/apache/arrow/pull/46830#discussion_r2150834151
##########
cpp/src/arrow/compute/CMakeLists.txt:
##########
@@ -50,7 +50,7 @@ if(ARROW_TESTING AND ARROW_COMPUTE)
# arrow_compute_core_testing so that is also included correctly
target_link_libraries(arrow_compute_testing
PUBLIC $<TARGET_OBJECTS:arrow_compute_core_testing>
- PUBLIC ${ARROW_GTEST_GTEST_MAIN})
+ PUBLIC ${ARROW_GTEST_GTEST})
Review Comment:
The Meson configuration was actually failing to register all of the compute
kernels (at least locally). When looking further into this, it appears that
googletest actually suggests providing your own main function when registering
a custom environment like this, to ensure that initialization happens in proper
order.
See also
https://github.com/google/googletest/blob/35b75a2cba6ef72b7ce2b6b94b05c54ca07df866/googletest/include/gtest/gtest.h#L1327
##########
cpp/subprojects/gtest.wrap:
##########
@@ -16,15 +16,15 @@
# under the License.
[wrap-file]
-directory = googletest-1.15.2
-source_url =
https://github.com/google/googletest/archive/refs/tags/v1.15.2.tar.gz
-source_filename = gtest-1.15.2.tar.gz
-source_hash = 7b42b4d6ed48810c5362c265a17faebe90dc2373c885e5216439d37927f02926
-patch_filename = gtest_1.15.2-1_patch.zip
-patch_url = https://wrapdb.mesonbuild.com/v2/gtest_1.15.2-1/get_patch
-patch_hash = b41cba05fc61d47b2ba5bf95732eb86ce2b67303f291b68a9587b7563c318141
-source_fallback_url =
https://github.com/mesonbuild/wrapdb/releases/download/gtest_1.15.2-1/gtest-1.15.2.tar.gz
-wrapdb_version = 1.15.2-1
+directory = googletest-1.17.0
Review Comment:
Without bumping googletest, it appears that a lot of the tests end up
failing with:
```
../subprojects/googletest-1.15.2/googletest/include/gtest/internal/gtest-port.h:1810::
pthread_key_delete(key_)failed with error 22
```
There's a large amount of discussion upstream in both the Meson WrapDB and
googletest about this, which ultimately traces back to the ODR and how gtest is
linked into an application.
I figure there's no harm in updating this, but happy to link to the further
discussions if anyone is interested
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
