WillAyd commented on code in PR #46830:
URL: https://github.com/apache/arrow/pull/46830#discussion_r2150855915


##########
cpp/src/arrow/meson.build:
##########
@@ -696,8 +711,8 @@ pkg.generate(
 subdir('testing')
 
 subdir('array')
-subdir('c')
 subdir('compute')
+subdir('c')

Review Comment:
   FWIW this is a minor deviation from the CMake configuration. In the CMake 
configuration, the `bridge_test` links to the `arrow_compute_XXX` libs, but 
those libs have not yet been declared because they are located in the 
compute/CMakeLists.txt file, which is included after c/CMakeLists.txt
   
   Without knowing how CMake works, I'm not sure if that's a problem or not, 
but the Meson configuration definitely complains about `arrow_compute_dep does 
not exist` if you try to maintain the same inclusion order as CMake



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to