raulcd commented on code in PR #46837:
URL: https://github.com/apache/arrow/pull/46837#discussion_r2153937457


##########
python/pyarrow/tests/test_fs.py:
##########
@@ -1475,6 +1475,37 @@ def test_azurefs_options(pickle_module):
     assert pickle_module.loads(pickle_module.dumps(fs4)) == fs4
     assert fs4 != fs3
 
+    fs5 = AzureFileSystem(
+        account_name='fake-account-name',
+        tenant_id='fake-tenant-id',
+        client_id='fake-client-id',
+        client_secret='fake-client-secret'
+    )
+    assert isinstance(fs5, AzureFileSystem)
+    assert pickle_module.loads(pickle_module.dumps(fs5)) == fs5
+    assert fs5 != fs4
+
+    with pytest.raises(ValueError, match="All of tenant_id, client_id, and 
client_secret must be provided"):

Review Comment:
   maybe you can create a variable `error_msg`, it will help get rid of the 
line length and reuse it below?
   ```suggestion
       error_msg = "All of tenant_id, client_id, and client_secret must be 
provided"
       with pytest.raises(ValueError, match=error_msg):
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to