raulcd commented on code in PR #46837:
URL: https://github.com/apache/arrow/pull/46837#discussion_r2166131438
##########
python/pyarrow/_azurefs.pyx:
##########
@@ -66,6 +66,15 @@ cdef class AzureFileSystem(FileSystem):
SAS token for the storage account, used as an alternative to
account_key. If sas_token
and account_key are None the default credential will be used. The
parameters
account_key and sas_token are mutually exclusive.
+ tenant_id : str, default None
+ Tenant ID for Azure Active Directory authentication. Must be provided
together with
+ `client_id` and `client_secret` to use ClientSecretCredential.
+ client_id : str, default None
+ Client ID for Azure Active Directory authentication. Must be provided
together with
+ `tenant_id` and `client_secret` to use ClientSecretCredential.
Review Comment:
I think it would be better to replicate the same functionality into the
Python bindings than the one we have for C++. As `client_id` can be used in
isolation in the C++ API with `ConfigureManagedIdentityCredential` and we are
adding it to the Python bindings now for `ConfigureManagedIdentityCredential` I
feel like we should add it for `ConfigureManagedIdentityCredential` too. It
doesn't seem like a great effort and we would replicate the full C++
functionality better. I understand that for your exact use case might not be
necessary but for the overall functionality I think it is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
