sgrebnov commented on code in PR #2961:
URL: https://github.com/apache/arrow-adbc/pull/2961#discussion_r2157532349
##########
csharp/src/Apache.Arrow.Adbc/Extensions/IArrowArrayExtensions.cs:
##########
@@ -103,6 +103,8 @@ public static class IArrowArrayExtensions
return ((Int64Array)arrowArray).GetValue(index);
case ArrowTypeId.String:
return ((StringArray)arrowArray).GetString(index);
+ case ArrowTypeId.LargeString:
+ return ((LargeStringArray)arrowArray).GetString(index);
Review Comment:
I'll double-check the supported types and reply back. Technically, Spice is
Arrow-based, so it natively supports all Arrow types (including those mentioned
above). We also use DataFusion as our query engine, which is also based on
native Arrow types—but there may still be some limitations.
Once I've verified everything, I'll be able to extend the types test.
Note: Spice supports reading directly from Parquet files, so we could simply
use a test Parquet file containing all supported Arrow types.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
