kou commented on code in PR #2961:
URL: https://github.com/apache/arrow-adbc/pull/2961#discussion_r2162584477
##########
compose.yaml:
##########
@@ -208,7 +208,7 @@ services:
DREMIO_JAVA_EXTRA_OPTS: "-Ddebug.addDefaultUser=true
-Ddremio.eula.disabled=true"
healthcheck:
test: [ "CMD", "curl", "--fail", "http://localhost:9047"; ]
- interval: 10s
+ interval: 5s
Review Comment:
Why do we need this?
##########
.github/workflows/integration.yml:
##########
@@ -323,3 +323,47 @@ jobs:
run: |
./ci/scripts/python_build.sh "$(pwd)" "$(pwd)/build"
env BUILD_DRIVER_MANAGER=0 ./ci/scripts/python_test.sh "$(pwd)"
"$(pwd)/build"
+
+ flightsql_interop:
+ name: "FlightSQL C# Interop"
+ runs-on: ubuntu-latest
+ steps:
+ - uses: actions/checkout@v4
+ with:
+ fetch-depth: 0
+ persist-credentials: false
+ - name: Get required Go version
+ run: |
+ (. .env && echo "GO_VERSION=${GO}") >> $GITHUB_ENV
+
+ - name: Get Date
+ id: get-date
+ run: |
+ echo "today=$(/bin/date -u '+%Y%m%d')" >> $GITHUB_OUTPUT
+
Review Comment:
It seems that this is not used.
```suggestion
```
##########
.github/workflows/integration.yml:
##########
@@ -323,3 +323,47 @@ jobs:
run: |
./ci/scripts/python_build.sh "$(pwd)" "$(pwd)/build"
env BUILD_DRIVER_MANAGER=0 ./ci/scripts/python_test.sh "$(pwd)"
"$(pwd)/build"
+
+ flightsql_interop:
+ name: "FlightSQL C# Interop"
+ runs-on: ubuntu-latest
+ steps:
+ - uses: actions/checkout@v4
+ with:
+ fetch-depth: 0
+ persist-credentials: false
+ - name: Get required Go version
+ run: |
+ (. .env && echo "GO_VERSION=${GO}") >> $GITHUB_ENV
+
+ - name: Get Date
+ id: get-date
+ run: |
+ echo "today=$(/bin/date -u '+%Y%m%d')" >> $GITHUB_OUTPUT
+
+ - uses: actions/setup-go@v5
+ with:
+ go-version: "${{ env.GO_VERSION }}"
+ check-latest: true
+ cache: true
+ cache-dependency-path: go/adbc/go.sum
+
+ - name: Build ADBC Driver
+ working-directory: go/adbc/pkg
+ run: |
+ make libadbc_driver_flightsql.so
+ ls -l
+
Review Comment:
```suggestion
```
##########
.github/workflows/integration.yml:
##########
@@ -323,3 +323,47 @@ jobs:
run: |
./ci/scripts/python_build.sh "$(pwd)" "$(pwd)/build"
env BUILD_DRIVER_MANAGER=0 ./ci/scripts/python_test.sh "$(pwd)"
"$(pwd)/build"
+
+ flightsql_interop:
+ name: "FlightSQL C# Interop"
+ runs-on: ubuntu-latest
+ steps:
+ - uses: actions/checkout@v4
+ with:
+ fetch-depth: 0
+ persist-credentials: false
+ - name: Get required Go version
+ run: |
+ (. .env && echo "GO_VERSION=${GO}") >> $GITHUB_ENV
+
+ - name: Get Date
+ id: get-date
+ run: |
+ echo "today=$(/bin/date -u '+%Y%m%d')" >> $GITHUB_OUTPUT
+
+ - uses: actions/setup-go@v5
+ with:
+ go-version: "${{ env.GO_VERSION }}"
+ check-latest: true
+ cache: true
+ cache-dependency-path: go/adbc/go.sum
+
Review Comment:
```suggestion
```
##########
csharp/test/Drivers/Interop/FlightSql/readme.md:
##########
@@ -83,3 +85,32 @@ simultaneously. To use multiple data sources, you can
configure them like:
...
}
```
+
+### Spice.ai OSS Configuration
+
+Use the following command to run a local test instance of Spice.ai OSS. An
example test configuration is available at
[flightsql-spiceai.json](/ci/configs/flightsql-spiceai.json).
+
+```bash
+docker-compose up spiceai-test
Review Comment:
```suggestion
docker compose up spiceai-test
```
##########
.github/workflows/integration.yml:
##########
@@ -323,3 +323,47 @@ jobs:
run: |
./ci/scripts/python_build.sh "$(pwd)" "$(pwd)/build"
env BUILD_DRIVER_MANAGER=0 ./ci/scripts/python_test.sh "$(pwd)"
"$(pwd)/build"
+
+ flightsql_interop:
+ name: "FlightSQL C# Interop"
+ runs-on: ubuntu-latest
+ steps:
+ - uses: actions/checkout@v4
+ with:
+ fetch-depth: 0
+ persist-credentials: false
+ - name: Get required Go version
+ run: |
+ (. .env && echo "GO_VERSION=${GO}") >> $GITHUB_ENV
+
+ - name: Get Date
+ id: get-date
+ run: |
+ echo "today=$(/bin/date -u '+%Y%m%d')" >> $GITHUB_OUTPUT
+
+ - uses: actions/setup-go@v5
+ with:
+ go-version: "${{ env.GO_VERSION }}"
+ check-latest: true
+ cache: true
+ cache-dependency-path: go/adbc/go.sum
+
+ - name: Build ADBC Driver
+ working-directory: go/adbc/pkg
+ run: |
+ make libadbc_driver_flightsql.so
+ ls -l
Review Comment:
Can we remove a debug print?
```suggestion
```
##########
.github/workflows/integration.yml:
##########
@@ -323,3 +323,47 @@ jobs:
run: |
./ci/scripts/python_build.sh "$(pwd)" "$(pwd)/build"
env BUILD_DRIVER_MANAGER=0 ./ci/scripts/python_test.sh "$(pwd)"
"$(pwd)/build"
+
+ flightsql_interop:
+ name: "FlightSQL C# Interop"
+ runs-on: ubuntu-latest
+ steps:
+ - uses: actions/checkout@v4
+ with:
+ fetch-depth: 0
+ persist-credentials: false
+ - name: Get required Go version
+ run: |
+ (. .env && echo "GO_VERSION=${GO}") >> $GITHUB_ENV
+
+ - name: Get Date
+ id: get-date
+ run: |
+ echo "today=$(/bin/date -u '+%Y%m%d')" >> $GITHUB_OUTPUT
+
+ - uses: actions/setup-go@v5
+ with:
+ go-version: "${{ env.GO_VERSION }}"
+ check-latest: true
+ cache: true
+ cache-dependency-path: go/adbc/go.sum
+
+ - name: Build ADBC Driver
+ working-directory: go/adbc/pkg
+ run: |
+ make libadbc_driver_flightsql.so
+ ls -l
+
+ - name: Start Test Servers
+ run: |
+ docker compose up --wait --detach spiceai-test
+
+ - name: Test Driver against Spice.ai OSS
+ env:
+ FLIGHTSQL_INTEROP_TEST_CONFIG_FILE:
"../../../../../ci/configs/flightsql-spiceai.json"
+ run: |
+ dotnet test
./csharp/test/Drivers/Interop/FlightSql/Apache.Arrow.Adbc.Tests.Drivers.Interop.FlightSql.csproj
+
Review Comment:
```suggestion
```
##########
.github/workflows/integration.yml:
##########
@@ -323,3 +323,47 @@ jobs:
run: |
./ci/scripts/python_build.sh "$(pwd)" "$(pwd)/build"
env BUILD_DRIVER_MANAGER=0 ./ci/scripts/python_test.sh "$(pwd)"
"$(pwd)/build"
+
+ flightsql_interop:
+ name: "FlightSQL C# Interop"
+ runs-on: ubuntu-latest
+ steps:
+ - uses: actions/checkout@v4
+ with:
+ fetch-depth: 0
+ persist-credentials: false
+ - name: Get required Go version
+ run: |
+ (. .env && echo "GO_VERSION=${GO}") >> $GITHUB_ENV
+
Review Comment:
```suggestion
```
##########
.github/workflows/integration.yml:
##########
@@ -323,3 +323,47 @@ jobs:
run: |
./ci/scripts/python_build.sh "$(pwd)" "$(pwd)/build"
env BUILD_DRIVER_MANAGER=0 ./ci/scripts/python_test.sh "$(pwd)"
"$(pwd)/build"
+
+ flightsql_interop:
+ name: "FlightSQL C# Interop"
+ runs-on: ubuntu-latest
+ steps:
+ - uses: actions/checkout@v4
+ with:
+ fetch-depth: 0
+ persist-credentials: false
+ - name: Get required Go version
+ run: |
+ (. .env && echo "GO_VERSION=${GO}") >> $GITHUB_ENV
+
+ - name: Get Date
+ id: get-date
+ run: |
+ echo "today=$(/bin/date -u '+%Y%m%d')" >> $GITHUB_OUTPUT
+
+ - uses: actions/setup-go@v5
+ with:
+ go-version: "${{ env.GO_VERSION }}"
+ check-latest: true
+ cache: true
+ cache-dependency-path: go/adbc/go.sum
+
+ - name: Build ADBC Driver
+ working-directory: go/adbc/pkg
+ run: |
+ make libadbc_driver_flightsql.so
+ ls -l
+
+ - name: Start Test Servers
+ run: |
+ docker compose up --wait --detach spiceai-test
+
Review Comment:
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
