alamb commented on code in PR #7714:
URL: https://github.com/apache/arrow-rs/pull/7714#discussion_r2159114019
##########
parquet/src/arrow/arrow_writer/mod.rs:
##########
@@ -320,14 +320,21 @@ impl<W: Write + Send> ArrowWriter<W> {
}
/// Returns a reference to the underlying writer.
+ ///
+ /// **Warning**: if you write directly to this writer, you will skip
Review Comment:
I was trying to say that using `inner()` is safe because it is immutable
(not `&mut`) and thus a caller can't use `inner()` to *write* to the underlying
stream (only to read)
I agree that the warning added to `inner_mut` is totally useful and valid. I
just think it might be confusing if the same warning is on `inner` as well. Or
perhaps I am missing something
> The low level we called by inner(), it has write_all api:
I thought the example that failed called `inner_mut()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
