zhuqi-lucas commented on code in PR #7714:
URL: https://github.com/apache/arrow-rs/pull/7714#discussion_r2159048868
##########
parquet/src/arrow/arrow_writer/mod.rs:
##########
@@ -320,14 +320,21 @@ impl<W: Write + Send> ArrowWriter<W> {
}
/// Returns a reference to the underlying writer.
+ ///
+ /// **Warning**: if you write directly to this writer, you will skip
+ /// the `TrackedWrite` buffering and byte‐counting layers. That’ll cause
+ /// the file footer’s recorded offsets and sizes to diverge from reality,
+ /// resulting in an unreadable or corrupted Parquet file.
pub fn inner(&self) -> &W {
self.writer.inner()
}
/// Returns a mutable reference to the underlying writer.
///
- /// It is inadvisable to directly write to the underlying writer, doing so
- /// will likely result in a corrupt parquet file
+ /// **Warning**: if you write directly to this writer, you will skip
+ /// the `TrackedWrite` buffering and byte‐counting layers. That’ll cause
+ /// the file footer’s recorded offsets and sizes to diverge from reality,
+ /// resulting in an unreadable or corrupted Parquet file.
pub fn inner_mut(&mut self) -> &mut W {
self.writer.inner_mut()
}
Review Comment:
Thank you @alamb , good suggestion!
Addressed in latest PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
