alamb commented on code in PR #7742:
URL: https://github.com/apache/arrow-rs/pull/7742#discussion_r2161576687
##########
arrow-pyarrow-testing/tests/pyarrow.rs:
##########
@@ -15,6 +15,28 @@
// specific language governing permissions and limitations
// under the License.
+//! Tests pyarrow bindings
+//!
+//! This test requires installing the `pyarrow` python package. If you do not
+//! have this package installed, you will see an error such as the following:
+//!
+//! ```text
+//! PyErr { type: <class 'ModuleNotFoundError'>, value:
ModuleNotFoundError("No module named 'pyarrow'"), traceback: None }
+//! ```
+//!
+//! # Notes
+//!
+//! You can not use a virtual environment to run these tests on MacOS, as it
will
+//! fail to find the pyarrow module due to
<https://github.com/PyO3/pyo3/issues/1741>
+//!
+//! One way to run them is to install the `pyarrow` package in the system
Python,
+//! which might break other packages, so use with caution:
+//!
+//! ```shell
+//! brew install pipx
+//! pip3 install --break-system-packages pyarrow
+//! ```
+
use arrow_array::builder::{BinaryViewBuilder, StringViewBuilder};
Review Comment:
the tests are unmodified -- I just added some comments about how to run the
tests locally
##########
.github/workflows/integration.yml:
##########
@@ -165,8 +165,9 @@ jobs:
- name: Run Rust tests
run: |
source venv/bin/activate
- cargo test -p arrow-pyarrow
- - name: Run tests
+ cd arrow-pyarrow-testing
Review Comment:
this is the key change -- move the tests to a different module
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
