KirillTsyganov commented on code in PR #46837:
URL: https://github.com/apache/arrow/pull/46837#discussion_r2166419156
##########
python/pyarrow/_azurefs.pyx:
##########
@@ -66,6 +66,15 @@ cdef class AzureFileSystem(FileSystem):
SAS token for the storage account, used as an alternative to
account_key. If sas_token
and account_key are None the default credential will be used. The
parameters
account_key and sas_token are mutually exclusive.
+ tenant_id : str, default None
+ Tenant ID for Azure Active Directory authentication. Must be provided
together with
+ `client_id` and `client_secret` to use ClientSecretCredential.
+ client_id : str, default None
+ Client ID for Azure Active Directory authentication. Must be provided
together with
+ `tenant_id` and `client_secret` to use ClientSecretCredential.
Review Comment:
@raulcd , all done, just pushed those changes. Just want to clarify
different `client_id` is required for `ClientSecretCredential` vs
`ManagedIdentityCredential`
I didn't want to add this bit of docs, cause it was bloating out
`AzureFileSystem` docs string. Should I add it in for clairity?
```
client_id : str, default None
The client ID (Application ID) for Azure Active Directory
authentication.
Its interpretation depends on the credential type being used:
- For `ClientSecretCredential`: It is the Application (client) ID of
your
registered Azure AD application (Service Principal). It must be
provided
together with `tenant_id` and `client_secret` to use
ClientSecretCredential.
- For `ManagedIdentityCredential`: It is the client ID of a specific
user-assigned managed identity. This is only necessary if you are
using a
user-assigned managed identity and need to explicitly specify
which one
(e.g., if the resource has multiple user-assigned identities). For
system-assigned managed identities, this parameter is typically
not required.
```
Cheers
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
