pitrou commented on code in PR #46870:
URL: https://github.com/apache/arrow/pull/46870#discussion_r2174986332
##########
cpp/cmake_modules/ThirdpartyToolchain.cmake:
##########
@@ -5102,6 +5102,10 @@ function(build_awssdk)
find_program(PATCH patch REQUIRED)
set(${BASE_VARIABLE_NAME}_PATCH_COMMAND
${PATCH} -p1 -i ${CMAKE_CURRENT_LIST_DIR}/aws-c-common-1208.patch)
+ elseif(MINGW AND AWSSDK_PRODUCT STREQUAL "aws-sdk-cpp")
+ find_program(PATCH patch REQUIRED)
+ set(${BASE_VARIABLE_NAME}_PATCH_COMMAND
+ ${PATCH} -p1 -i ${CMAKE_CURRENT_LIST_DIR}/aws-sdk-cpp.diff)
Review Comment:
Can we keep naming all patches with the `.patch` extension?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
