kou commented on code in PR #46870:
URL: https://github.com/apache/arrow/pull/46870#discussion_r2176465819
##########
cpp/cmake_modules/aws-sdk-cpp.diff:
##########
@@ -0,0 +1,12 @@
+diff --git a/generated/src/aws-cpp-sdk-s3/source/S3Client.cpp
b/generated/src/aws-cpp-sdk-s3/source/S3Client.cpp
Review Comment:
This doesn't solve the upstream issue...
I'll suppress this false positive detection.
##########
cpp/cmake_modules/ThirdpartyToolchain.cmake:
##########
@@ -5102,6 +5102,10 @@ function(build_awssdk)
find_program(PATCH patch REQUIRED)
set(${BASE_VARIABLE_NAME}_PATCH_COMMAND
${PATCH} -p1 -i ${CMAKE_CURRENT_LIST_DIR}/aws-c-common-1208.patch)
+ elseif(MINGW AND AWSSDK_PRODUCT STREQUAL "aws-sdk-cpp")
+ find_program(PATCH patch REQUIRED)
+ set(${BASE_VARIABLE_NAME}_PATCH_COMMAND
+ ${PATCH} -p1 -i ${CMAKE_CURRENT_LIST_DIR}/aws-sdk-cpp.diff)
Review Comment:
(I'll remove this diff because this diff doesn't solve anything.)
In general, I'm using `.diff` for `diff -u`/`git diff` output and `.patch`
for `git format-patch` output like GitHub does:
* https://github.com/apache/arrow/pull/46870.diff
* https://github.com/apache/arrow/pull/46870.patch
I used `.diff` here because it's just for testing. I'm using `.patch` for
the final result.
Sorry for not marking this PR as draft.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
