ianmcook commented on a change in pull request #9952:
URL: https://github.com/apache/arrow/pull/9952#discussion_r610799756
##########
File path: r/R/arrow-datum.R
##########
@@ -22,6 +22,7 @@
ArrowDatum <- R6Class("ArrowDatum", inherit = ArrowObject,
public = list(
cast = function(target_type, safe = TRUE, ...) {
+ target_type <- unmask_type_fun(enexpr(target_type)) %||% target_type
Review comment:
Re the `%||% type` thing: To create a foolproof escape hatch for when
the NSE approach fails to evaluate `type` properly, you need to evaluate `type`
in the calling environment, not in this function or another function called
from this function.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
