ianmcook commented on a change in pull request #9952: URL: https://github.com/apache/arrow/pull/9952#discussion_r610846596
########## File path: r/R/arrow-datum.R ########## @@ -22,6 +22,7 @@ ArrowDatum <- R6Class("ArrowDatum", inherit = ArrowObject, public = list( cast = function(target_type, safe = TRUE, ...) { + target_type <- unmask_type_fun(enexpr(target_type)) %||% target_type Review comment: P.S. If every call to `as_type()` happened at a fixed number of function calls `n` from the calling environment, then we could simply evaluate the defused expression `type` there, using `eval.parent(type, n)`. That would allow us to encapsulate all the NSE evaluation in `as_type()`. But that's not the case. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org