kou commented on code in PR #46932:
URL: https://github.com/apache/arrow/pull/46932#discussion_r2178785785
##########
cpp/src/parquet/arrow/reader.cc:
##########
@@ -1310,28 +1310,6 @@ std::shared_ptr<RowGroupReader>
FileReaderImpl::RowGroup(int row_group_index) {
// ----------------------------------------------------------------------
// Public factory functions
-Status FileReader::GetRecordBatchReader(std::shared_ptr<RecordBatchReader>*
out) {
- ARROW_ASSIGN_OR_RAISE(auto tmp, GetRecordBatchReader());
- out->reset(tmp.release());
- return Status::OK();
-}
-
-Status FileReader::GetRecordBatchReader(const std::vector<int>&
row_group_indices,
- std::shared_ptr<RecordBatchReader>*
out) {
- ARROW_ASSIGN_OR_RAISE(auto tmp, GetRecordBatchReader(row_group_indices));
- out->reset(tmp.release());
- return Status::OK();
-}
-
-Status FileReader::GetRecordBatchReader(const std::vector<int>&
row_group_indices,
- const std::vector<int>& column_indices,
- std::shared_ptr<RecordBatchReader>*
out) {
- ARROW_ASSIGN_OR_RAISE(auto tmp,
- GetRecordBatchReader(row_group_indices,
column_indices));
- out->reset(tmp.release());
- return Status::OK();
-}
-
Review Comment:
Could you keep them? Users who still use old API use them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
