pitrou commented on code in PR #46017:
URL: https://github.com/apache/arrow/pull/46017#discussion_r2179565092
##########
cpp/src/parquet/encryption/test_encryption_util.h:
##########
@@ -40,12 +41,13 @@ class ParquetFileReader;
namespace encryption::test {
using ::arrow::internal::TemporaryDir;
+using ::arrow::util::SecureString;
constexpr int kFixedLength = 10;
-const char kFooterEncryptionKey[] = "0123456789012345"; // 128bit/16
-const char kColumnEncryptionKey1[] = "1234567890123450";
-const char kColumnEncryptionKey2[] = "1234567890123451";
+inline SecureString kFooterEncryptionKey("0123456789012345");
+inline SecureString kColumnEncryptionKey1("1234567890123450");
+inline SecureString kColumnEncryptionKey2("1234567890123451");
Review Comment:
Nit, but perhaps we can make these `const`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
