pitrou commented on code in PR #46017:
URL: https://github.com/apache/arrow/pull/46017#discussion_r2179567415
##########
cpp/src/parquet/encryption/local_wrap_kms_client.h:
##########
@@ -35,16 +35,16 @@ class PARQUET_EXPORT LocalWrapKmsClient : public KmsClient {
explicit LocalWrapKmsClient(const KmsConnectionConfig&
kms_connection_config);
- std::string WrapKey(const std::string& key_bytes,
+ std::string WrapKey(const ::arrow::util::SecureString& key_bytes,
const std::string& master_key_identifier) override;
- std::string UnwrapKey(const std::string& wrapped_key,
- const std::string& master_key_identifier) override;
+ ::arrow::util::SecureString UnWrapKey(
Review Comment:
Isn't it a bit gratuitous to change the method name casing from `UnwrapKey`
to `UnWrapKey`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
