hadrian-reppas commented on code in PR #46961:
URL: https://github.com/apache/arrow/pull/46961#discussion_r2192465885
##########
python/pyarrow/lib.pxd:
##########
@@ -678,6 +678,8 @@ cdef shared_ptr[const CKeyValueMetadata]
pyarrow_unwrap_metadata(
cdef object pyarrow_wrap_metadata(
const shared_ptr[const CKeyValueMetadata]& meta)
+cdef CField.CMergeOptions _parse_field_merge_options(str promote_options, bint
allow_none) except *
Review Comment:
It might actually be nicer to remove the parameter completely. We only allow
"none" in one place so for that call we could just do
```python
_parse_field_merge_options("default" if promote_options == "none" else
promote_options)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
