ggershinsky commented on pull request #9817: URL: https://github.com/apache/arrow/pull/9817#issuecomment-817578210
had a quick look at the encryption part, no specific comments, seems to be well structured and coded; as long as it interoperates with its C++ counterpart (can read/decrypt the files written/encrypted by the other), it should be ok - but this is applicable to all other parquet features as well :) this pull request covers the so-called "low level" encryption layer. On top of it, parquet also has a "high-level" encryption layer, please see the [explanation](https://docs.google.com/document/d/1i1M5f5azLEmASj9XQZ_aQLl5Fr5F0CvnyPPVu1xaD9U/edit#heading=h.797chtbkcg0l ) of differences and reasons. The high level layer is already released in Java parquet (v1.12.0), that went into Spark master for the next Spark release. This layer is also implemented in C++, and merged in Arrow (https://github.com/apache/arrow/pull/8023). You might consider adding this layer to the Go implementation as well, so it will be able to interop with Spark and PyArrow, and will benefit from the additional security checks/features. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
