alamb commented on code in PR #7911:
URL: https://github.com/apache/arrow-rs/pull/7911#discussion_r2203365113
##########
parquet-variant/src/builder.rs:
##########
@@ -61,9 +61,21 @@ fn write_offset(buf: &mut Vec<u8>, value: usize, nbytes: u8)
{
buf.extend_from_slice(&bytes[..nbytes as usize]);
}
-#[derive(Default)]
+#[derive(Debug, Default)]
struct ValueBuffer(Vec<u8>);
+impl ValueBuffer {
+ /// Construct a ValueBuffer that will write to a new underlying `Vec`
+ fn new() -> Self {
+ Default::default()
+ }
+
+ /// Construct a ValueBuffer from an existing buffer
+ fn from_existing(existing: Vec<u8>) -> Self {
Review Comment:
I have implemented this change in
https://github.com/apache/arrow-rs/pull/7912
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
