alamb commented on code in PR #7911:
URL: https://github.com/apache/arrow-rs/pull/7911#discussion_r2211513806
##########
parquet-variant/src/builder.rs:
##########
@@ -1047,16 +1047,16 @@ impl Drop for ObjectBuilder<'_> {
///
/// Allows users to append values to a [`VariantBuilder`], [`ListBuilder`] or
/// [`ObjectBuilder`]. using the same interface.
-pub trait VariantBuilderExt<'m, 'v> {
- fn append_value(&mut self, value: impl Into<Variant<'m, 'v>>);
+pub trait VariantBuilderExt {
Review Comment:
There is no reason for the lifetimes to be attached to the trait itself --
if it is that means that the lifetimes trickle into the values -- since this
trait is for actually constructing variant values (and copying the underlying
bytes) I moved the lifetimes to just the arguments that need it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
