pitrou commented on code in PR #12865: URL: https://github.com/apache/arrow/pull/12865#discussion_r2207977771
########## cpp/src/arrow/compute/kernels/temporal_internal.h: ########## @@ -40,15 +39,42 @@ using arrow_vendored::date::year_month_day; using arrow_vendored::date::zoned_time; using std::chrono::duration_cast; +using ArrowTimeZone = std::variant<const time_zone*, const OffsetZone>; + +template <class... Ts> Review Comment: Yes, but also mention the source of this code (presumably some page on cppreference.com ?). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
