pitrou commented on code in PR #12865:
URL: https://github.com/apache/arrow/pull/12865#discussion_r2208264161
##########
cpp/src/arrow/compute/kernels/temporal_internal.h:
##########
@@ -128,22 +162,31 @@ struct ZonedLocalizer {
template <typename Duration>
struct TimestampFormatter {
const char* format;
- const time_zone* tz;
+ const ArrowTimeZone tz_;
std::ostringstream bufstream;
- explicit TimestampFormatter(const std::string& format, const time_zone* tz,
+ explicit TimestampFormatter(const std::string& format, const ArrowTimeZone
tz,
const std::locale& locale)
- : format(format.c_str()), tz(tz) {
+ : format(format.c_str()), tz_(tz) {
bufstream.imbue(locale);
// Propagate errors as C++ exceptions (to get an actual error message)
bufstream.exceptions(std::ios::failbit | std::ios::badbit);
}
Result<std::string> operator()(int64_t arg) {
bufstream.str("");
- const auto zt = zoned_time<Duration>{tz,
sys_time<Duration>(Duration{arg})};
+ const auto visitor = overloads{
Review Comment:
This error is not related to what I suggested, is it? Note the `Func`
argument that reconciles the return types.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
