lidavidm commented on code in PR #47139: URL: https://github.com/apache/arrow/pull/47139#discussion_r2227558375
########## python/pyarrow/types.py: ########## @@ -46,6 +48,79 @@ lib.Type_STRUCT, lib.Type_MAP} | _UNION_TYPES +class TypesEnum(Enum): Review Comment: The order does not matter because we are explicitly setting the values (though keeping the order the same might make it easier to see where they are out of sync in the future), but yeah, I was wondering this because `DataType.id` is `int` (as it has to be, since it existed before the enum) and so it would be a little easier if the enum were IntEnum -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org