rmnskb commented on code in PR #47139:
URL: https://github.com/apache/arrow/pull/47139#discussion_r2229418697
##########
python/pyarrow/types.py:
##########
@@ -46,6 +48,79 @@
lib.Type_STRUCT, lib.Type_MAP} | _UNION_TYPES
+class TypesEnum(Enum):
Review Comment:
Hey @lidavidm , thanks for the suggestion!s I've changed the `Enum` to
`IntEnum` and updated the docstrings examples accordingly.
Regarding the order: I recon one way or another the order is arbitrary, as
you mentioned, since we map them to existing values. I tried to maintain the
same order as the order of types implementation on the C++ side
[here](https://github.com/apache/arrow/blob/main/cpp/src/arrow/type.h).
However, I also thought that visually grouping together integers and unsigned
integers makes sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
