alamb commented on PR #7946: URL: https://github.com/apache/arrow-rs/pull/7946#issuecomment-3115119572
> @scovitch has mentioned (https://github.com/apache/arrow-rs/pull/7935) that efficient, in-place Variant mutators are a piece that's still missing. Field removal naturally fits into a PR focused on that functionality. I don't really understand why in-place mutations are needed to implement `get` for VariantArray. I think that would only be necessary (potentially) for writing shredded values 🤔 It seems to me that we already have 1. `Variant::get_path` to get some arbitrary path from a single `Variant`: https://github.com/apache/arrow-rs/blob/16794ab14fa62ecf67de0da9460cc5752a9358f4/parquet-variant/src/variant.rs#L1076-L1103 2. The `variant_get` compute kernel to extract a column of variants from a VariantArray : https://github.com/apache/arrow-rs/blob/16794ab14fa62ecf67de0da9460cc5752a9358f4/parquet-variant-compute/src/variant_get.rs#L35 What we are missing from the read side from what I can tell is the ability to read shredded variants (aka VariantArrays where the underlying array has a `typed_value` field) What would you think about trying to implement the code to make the tests in https://github.com/apache/arrow-rs/pull/7965 work? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
