kou commented on PR #47114:
URL: https://github.com/apache/arrow/pull/47114#issuecomment-3116271534
> you could achieve this with a command line option to the compiler and get
rid of the push as well
Can we use this approach something like the following?
```diff
diff --git a/cpp/src/parquet/CMakeLists.txt b/cpp/src/parquet/CMakeLists.txt
index dc7d40d2a3..717496496a 100644
--- a/cpp/src/parquet/CMakeLists.txt
+++ b/cpp/src/parquet/CMakeLists.txt
@@ -352,6 +352,18 @@ foreach(LIB_TARGET ${PARQUET_LIBRARIES})
endif()
endforeach()
+# Disable warnings
+foreach(LIB_TARGET ${PARQUET_LIBRARIES})
+ if(MSVC)
+ # Disable warning for STL types usage in DLL interface
+ #
https://web.archive.org/web/20130317015847/http://connect.microsoft.com/VisualStudio/feedback/details/696593/vc-10-vs-2010-basic-string-exports
+ target_compile_options(${LIB_TARGET} PUBLIC "/wd4275" "/wd4251")
+ # Disable diamond inheritance warnings
+ target_compile_options(${LIB_TARGET} PRIVATE "/wd4250")
+ ...
+ endif()
+endforeach()
+
if(WIN32 AND ARROW_BUILD_STATIC)
target_compile_definitions(parquet_static PUBLIC PARQUET_STATIC)
endif()
```
We can use `PRIVATE` for warnings that are only for Parquet source.
We can use `PUBLIC` for warnings that are for Parquet source and Parquet
users.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
