behrisch commented on PR #47114:
URL: https://github.com/apache/arrow/pull/47114#issuecomment-3157857923
I totally agree, I just tried to adapt to the style of the surrounding code
Am 5. August 2025 07:31:53 GMT+01:00 schrieb Sutou Kouhei ***@***.***>:
>@kou commented on this pull request.
>
>
>
>> @@ -26,6 +26,21 @@
> #include "arrow/util/string_util.h"
> #include "parquet/platform.h"
>
>+#if defined(_WIN32) || defined(__CYGWIN__)
>
>Can we remove this? It seems that `#ifdef _MSC_VER` is enough.
>
>```suggestion
>```
>
>> @@ -156,3 +171,9 @@ void ThrowNotOk(StatusReturnBlock&& b) {
> }
>
> } // namespace parquet
>+
>+#if defined(_WIN32) || defined(__CYGWIN__)
>
>ditto.
>
>> @@ -110,3 +110,9 @@ std::shared_ptr<ResizableBuffer> AllocateBuffer(
> ::arrow::MemoryPool* pool = ::arrow::default_memory_pool(), int64_t
size = 0);
>
> } // namespace parquet
>+
>+#if defined(_WIN32) || defined(__CYGWIN__)
>
>ditto.
>
>--
>Reply to this email directly or view it on GitHub:
>https://github.com/apache/arrow/pull/47114#pullrequestreview-3086785557
>You are receiving this because you authored the thread.
>
>Message ID: ***@***.***>
--
Diese Nachricht wurde von meinem Android-Gerät mit K-9 Mail gesendet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
