eitsupi commented on code in PR #3197:
URL: https://github.com/apache/arrow-adbc/pull/3197#discussion_r2244136404
##########
rust/driver_manager/src/lib.rs:
##########
@@ -720,6 +712,7 @@ fn set_option_database(
ERR_ONLY_STRING_OPT,
Status::NotImplemented,
))?,
+ (_, _) => unreachable!(),
Review Comment:
Thank you for your reply. (And sorry for the late comment, I was wondering
about this a few days ago but forgot to post the question.)
I understand that the version number will be expanded in the future, but I
think that if a driver and driver manager combination with an unknown version
is encountered, an error will eventually occur.
https://github.com/apache/arrow-adbc/blob/314f0096b50538df8b4d4b34f95273481c22a7ad/rust/core/src/options.rs#L136-L149
This is the same whether the enum is marked with `non_exhaustive` or not, so
I think it is better to remove the `non_exhaustive` attribute to make it clear
that all versions at the time of release of adbc_core are supported, and to
prevent bugs from being introduced during downstream package development.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
