lidavidm commented on code in PR #3197:
URL: https://github.com/apache/arrow-adbc/pull/3197#discussion_r2244142378
##########
rust/driver_manager/src/lib.rs:
##########
@@ -720,6 +712,7 @@ fn set_option_database(
ERR_ONLY_STRING_OPT,
Status::NotImplemented,
))?,
+ (_, _) => unreachable!(),
Review Comment:
I think I might be misunderstanding, but isn't the intent of
`non_exhaustive` for downstream users, not our own code? In other words, the
intent is to prevent people from writing code like this:
```rust
match version {
AdbcVersion::V100 => ...,
AdbcVersion::V110 => ...,
// No other clauses
}
```
so that they can't complain about broken code when we add a new version. I
suppose now that we are splitting the crates, it does mean some redundancy in
our own code. But I would argue that since we do plan on expanding this enum,
we should be explicit about our plans with the attribute, especially for users
outside this repo.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
