jecsand838 commented on code in PR #8006:
URL: https://github.com/apache/arrow-rs/pull/8006#discussion_r2248512537
##########
arrow-avro/src/codec.rs:
##########
@@ -180,15 +182,15 @@ impl<'a> TryFrom<&Schema<'a>> for AvroField {
/// Builder for an [`AvroField`]
#[derive(Debug)]
pub struct AvroFieldBuilder<'a> {
- writer_schema: &'a Schema<'a>,
- reader_schema: Option<&'a Schema<'a>>,
+ writer_schema: &'a AvroSchema<'a>,
+ reader_schema: Option<&'a AvroSchema<'a>>,
Review Comment:
I originally thought the same and my personal preference was to refer to it
as `Schema`.
Then I thought it maybe easier for people who aren't familiar with this
crate to read the code if it was aliased as `AvroSchema`. Due to the size of
this PR though, I can just revert it back for now. It would probably be best to
tackle it explicitly in a dedicated PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
