jecsand838 commented on code in PR #8006:
URL: https://github.com/apache/arrow-rs/pull/8006#discussion_r2248586749
##########
arrow-avro/src/schema.rs:
##########
@@ -467,37 +465,50 @@ impl<'a> SchemaStore<'a> {
}
}
-#[inline]
fn quote(s: &str) -> Result<String, ArrowError> {
serde_json::to_string(s)
.map_err(|e| ArrowError::ComputeError(format!("Failed to quote string:
{e}")))
}
-fn make_fullname(name: &str, namespace_attr: Option<&str>, enclosing_ns:
Option<&str>) -> String {
- match namespace_attr.or(enclosing_ns) {
- Some(ns) if !name.contains('.') => format!("{ns}.{name}"),
- _ => name.to_string(),
+// Avro names are defined by a `name` and an optional `namespace`.
+// The full name is composed of the namespace and the name, separated by a dot.
+//
+// Avro specification defines two ways to specify a full name:
+// 1. The `name` attribute contains the full name (e.g., "a.b.c.d").
+// In this case, the `namespace` attribute is ignored.
+// 2. The `name` attribute contains the simple name (e.g., "d") and the
+// `namespace` attribute contains the namespace (e.g., "a.b.c").
+//
+// Each part of the name must match the regex `^[A-Za-z_][A-Za-z0-9_]*$`.
+// Complex paths with quotes or backticks like `a."hi".b` are not supported.
+//
+// This function constructs the full name and extracts the namespace,
+// handling both ways of specifying the name. It prioritizes a namespace
+// defined within the `name` attribute itself, then the explicit
`namespace_attr`,
+// and finally the `enclosing_ns`.
+fn make_full_name(
+ name: &str,
+ namespace_attr: Option<&str>,
+ enclosing_ns: Option<&str>,
+) -> Result<(String, Option<String>), ArrowError> {
Review Comment:
I iterated on this function a few times last night and neglected to update
the signature. I'll get that handled.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
