klion26 commented on code in PR #8041:
URL: https://github.com/apache/arrow-rs/pull/8041#discussion_r2253106687
##########
arrow-buffer/src/bigint/mod.rs:
##########
@@ -586,6 +586,25 @@ impl i256 {
pub const fn is_positive(self) -> bool {
self.high.is_positive() || self.high == 0 && self.low != 0
}
+
+ fn leading_zeros(&self) -> u32 {
+ match self.high {
+ 0 => 128 + self.low.leading_zeros(),
+ _ => self.high.leading_zeros(),
+ }
+ }
+
+ fn redundant_leading_sign_bits_i256(n: i256) -> u8 {
Review Comment:
Changed the return type to `u8` because line 604 needs `k` be `u8` and the
largest value here is 255
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
