klion26 commented on PR #8041: URL: https://github.com/apache/arrow-rs/pull/8041#issuecomment-3153348556
Added a benchmark for the `to_f64` function and made a benchmark on different branches 1. The main branch (`i256_to_f64_base` in the result) 2. The current implementation(`8013_improve_performance_of_i256_to_f64` in the benchamark result) The result shows that the current implementation has improvements. ``` group 8013_improve_performance_of_i256_to_f64 i256_to_f64_base ----- --------------------------------------- ---------------- ......................... omitted the other benchmark results................ i256_to_f64(-1) 1.00 9.6±0.34ns ? ?/sec 1.15 11.0±0.36ns ? ?/sec i256_to_f64(-1233456789) 1.00 9.3±0.20ns ? ?/sec 1.17 10.9±0.30ns ? ?/sec i256_to_f64(-170141183460469231731687303715884105728) 1.00 9.7±0.32ns ? ?/sec 1.12 10.9±0.21ns ? ?/sec i256_to_f64(-57896044618658097711785492504343953926634992332820282019728792003956564819968) 1.00 1.5±0.04ns ? ?/sec 1.85 2.7±0.13ns ? ?/sec i256_to_f64(0) 1.00 1.9±0.06ns ? ?/sec 5.62 10.9±0.38ns ? ?/sec i256_to_f64(1) 1.00 1.5±0.05ns ? ?/sec 7.38 10.8±0.41ns ? ?/sec i256_to_f64(1233456789) 1.00 9.3±0.27ns ? ?/sec 1.17 10.9±0.33ns ? ?/sec i256_to_f64(170141183460469231731687303715884105727) 1.00 9.7±0.43ns ? ?/sec 1.12 10.9±0.26ns ? ?/sec i256_to_f64(57896044618658097711785492504343953926634992332820282019728792003956564819967) 1.00 10.4±0.27ns ? ?/sec 1.05 10.9±0.46ns ? ?/sec ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org