etseidl commented on code in PR #8048:
URL: https://github.com/apache/arrow-rs/pull/8048#discussion_r2258293451
##########
parquet/src/basic.rs:
##########
@@ -817,6 +877,90 @@ impl From<ConvertedType> for
Option<parquet::ConvertedType> {
}
}
+// ----------------------------------------------------------------------
+// parquet::BloomFilterHash <=> BloomFilterHash conversion
+
+impl From<parquet::BloomFilterHash> for BloomFilterHash {
+ fn from(value: parquet::BloomFilterHash) -> Self {
+ match value {
+ parquet::BloomFilterHash::XXHASH(_) => BloomFilterHash::XXHASH,
+ }
+ }
+}
+
+impl From<BloomFilterHash> for parquet::BloomFilterHash {
Review Comment:
I can do that...I was debating it and got lazy reasoning that `format` will
eventually go away and with it the confusion. But it would make it easier to
see what's going on in the interim. I've already tried to get rid of `use
crate::format` so that anything using `format` will be immediately apparent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
