etseidl commented on code in PR #8048: URL: https://github.com/apache/arrow-rs/pull/8048#discussion_r2258301305
########## parquet/src/basic.rs: ########## @@ -817,6 +877,90 @@ impl From<ConvertedType> for Option<parquet::ConvertedType> { } } +// ---------------------------------------------------------------------- +// parquet::BloomFilterHash <=> BloomFilterHash conversion + +impl From<parquet::BloomFilterHash> for BloomFilterHash { Review Comment: Yes, this is a stepping stone. Eventually there will be a single `BloomFilterHash` (or any other thrift based struct/enum) that is populated directly from a reader much like `TCompactSliceInputProtocol`. Once this merges the next PR which is almost ready to go converts a number of thrift enums and unions to the new parser. This step will need a lot of feedback/help. I have something that works, but there are warts. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org