hiroyuki-sato opened a new pull request, #47274:
URL: https://github.com/apache/arrow/pull/47274
### Rationale for this change
This is the sub issue #44748.
* SC1091: Not following
* SC2086: Double quote to prevent globbing and word splitting.
* SC2164: Use `cd ... || exit` in case `cd` fails
```
shellcheck ci/scripts/python_benchmark.sh
In ci/scripts/python_benchmark.sh line 23:
source deactivate
^--------^ SC1091 (info): Not following: deactivate: openBinaryFile:
does not exist (No such file or directory)
In ci/scripts/python_benchmark.sh line 24:
conda create -y -q -n pyarrow_asv python=$PYTHON_VERSION
^-------------^ SC2086 (info):
Double quote to prevent globbing and word splitting.
Did you mean:
conda create -y -q -n pyarrow_asv python="$PYTHON_VERSION"
In ci/scripts/python_benchmark.sh line 32:
pushd $ARROW_PYTHON_DIR
^---------------------^ SC2164 (warning): Use 'pushd ... || exit' or 'pushd
... || return' in case pushd fails.
^---------------^ SC2086 (info): Double quote to prevent globbing and
word splitting.
Did you mean:
pushd "$ARROW_PYTHON_DIR" || exit
In ci/scripts/python_benchmark.sh line 35:
git fetch --depth=100 origin $DEFAULT_BRANCH:$DEFAULT_BRANCH
^-------------^ SC2086 (info): Double quote to
prevent globbing and word splitting.
^-------------^ SC2086 (info):
Double quote to prevent globbing and word splitting.
Did you mean:
git fetch --depth=100 origin "$DEFAULT_BRANCH":"$DEFAULT_BRANCH"
In ci/scripts/python_benchmark.sh line 40:
popd # $ARROW_PYTHON_DIR
^--^ SC2164 (warning): Use 'popd ... || exit' or 'popd ... || return' in
case popd fails.
Did you mean:
popd || exit # $ARROW_PYTHON_DIR
For more information:
https://www.shellcheck.net/wiki/SC2164 -- Use 'popd ... || exit' or 'popd
....
https://www.shellcheck.net/wiki/SC1091 -- Not following: deactivate:
openBi...
https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing
...
```
### What changes are included in this PR?
* SC1091: disable test
* SC2086: Quote variables.
* SC2164: Use `... || exit`
### Are these changes tested?
Yes.
### Are there any user-facing changes?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
