kou commented on code in PR #47274: URL: https://github.com/apache/arrow/pull/47274#discussion_r2261961460
########## ci/scripts/python_benchmark.sh: ########## @@ -20,21 +20,26 @@ # Check the ASV benchmarking setup. # Unfortunately this won't ensure that all benchmarks succeed # (see https://github.com/airspeed-velocity/asv/issues/449) +# +# We don't need to follow this external file. +# See also: https://www.shellcheck.net/wiki/SC1091 +# +# shellcheck source=/dev/null source deactivate -conda create -y -q -n pyarrow_asv python=$PYTHON_VERSION +conda create -y -q -n pyarrow_asv python="$PYTHON_VERSION" conda activate pyarrow_asv pip install -q git+https://github.com/pitrou/asv.git@customize_commands export PYARROW_WITH_PARQUET=1 export PYARROW_WITH_ORC=0 export PYARROW_WITH_GANDIVA=0 -pushd $ARROW_PYTHON_DIR +pushd "$ARROW_PYTHON_DIR" || exit 1 Review Comment: Could you use `set -e` instead of `|| exit`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
