toddmeng-db commented on code in PR #3217:
URL: https://github.com/apache/arrow-adbc/pull/3217#discussion_r2261193792
##########
csharp/src/Drivers/Databricks/CloudFetch/CloudFetchResultFetcher.cs:
##########
@@ -160,8 +161,11 @@ public async Task StopAsync()
request.StartRowOffset = offset;
+ // Cancelling mid-request breaks the client; Dispose() should
not break the underlying client
+ CancellationToken expiringToken =
ApacheUtility.GetCancellationToken(DatabricksConstants.DefaultCloudFetchRequestTimeoutSeconds,
ApacheUtility.TimeUnit.Seconds);
Review Comment:
Oh got it, that makes sense, it should be a configurable parameter. To be
consistent with the rest of HiveServer2Statement, I'm just using the
QueryTimeout parameter (which is what other FetchResultsRequest uses) - is this
acceptable? @jackyhu-db
I have some changes in a follow-up PR that will make this change easier to
do for DatabricksReader, will leave this as a TODO
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
