toddmeng-db commented on code in PR #3217:
URL: https://github.com/apache/arrow-adbc/pull/3217#discussion_r2260938708
##########
csharp/src/Drivers/Databricks/CloudFetch/CloudFetchResultFetcher.cs:
##########
@@ -160,8 +161,11 @@ public async Task StopAsync()
request.StartRowOffset = offset;
+ // Cancelling mid-request breaks the client; Dispose() should
not break the underlying client
+ CancellationToken expiringToken =
ApacheUtility.GetCancellationToken(DatabricksConstants.DefaultCloudFetchRequestTimeoutSeconds,
ApacheUtility.TimeUnit.Seconds);
Review Comment:
Do you mean I shouldn't create a new constant here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
