lidavidm commented on code in PR #3245:
URL: https://github.com/apache/arrow-adbc/pull/3245#discussion_r2261684322
##########
rust/core/src/options.rs:
##########
@@ -150,7 +149,6 @@ impl FromStr for AdbcVersion {
/// Info codes for database/driver metadata.
#[derive(Copy, Clone, Debug, PartialEq, Eq, Hash)]
-#[non_exhaustive]
Review Comment:
Hmm, I expect this will expand over time
##########
rust/core/src/options.rs:
##########
@@ -277,7 +274,6 @@ impl TryFrom<c_int> for ObjectDepth {
/// Database option key.
#[derive(PartialEq, Eq, Hash, Debug, Clone)]
-#[non_exhaustive]
Review Comment:
I would say this (and other Option* enums) will also expand over time for
sure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
