eitsupi commented on PR #3245: URL: https://github.com/apache/arrow-adbc/pull/3245#issuecomment-3175053821
Thank you both, and sorry for including some obviously unnecessary changes. The problem I think is that there is too much `non_exhaustive`, which means that downstream users won't notice the upstream changes unless they use `non_exhaustive_omitted_patterns`, which is not currently easily available. My suggestion is that it would be better to remove `non_exhaustive` from places other than where this property is truly considered useful. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
