kczimm commented on code in PR #8071:
URL: https://github.com/apache/arrow-rs/pull/8071#discussion_r2263824008


##########
parquet/src/file/metadata/reader.rs:
##########
@@ -593,7 +642,15 @@ impl ParquetMetaDataReader {
                                     col_idx,
                                 )
                             }
-                            None => Err(general_err!("missing offset index")),
+                            None => {
+                                if self.offset_index == 
PageIndexPolicy::Required {
+                                    return Err(general_err!("missing offset 
index"));
+                                }
+                                Ok(OffsetIndexMetaData {

Review Comment:
   I've changed it based on @etseidl feedback. Now if we just set the column 
and offset index to None and return. What do you think about this approach?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to