kczimm commented on code in PR #8071:
URL: https://github.com/apache/arrow-rs/pull/8071#discussion_r2274351145
##########
parquet/src/file/metadata/reader.rs:
##########
@@ -118,27 +139,46 @@ impl ParquetMetaDataReader {
}
/// Enable or disable reading the page index structures described in
- /// "[Parquet page index]: Layout to Support Page Skipping". Equivalent to:
- /// `self.with_column_indexes(val).with_offset_indexes(val)`
+ /// "[Parquet page index]: Layout to Support Page Skipping".
///
/// [Parquet page index]:
https://github.com/apache/parquet-format/blob/master/PageIndex.md
pub fn with_page_indexes(self, val: bool) -> Self {
Review Comment:
I agree! I had the same thought but didn't feel comfortable suggesting
deprecation of APIs created by others, especially as a new contributor to this
project. (and I didn't see there were guidelines). I'll go ahead and read the
guidelines and update this PR accordingly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
