toddmeng-db commented on code in PR #3241:
URL: https://github.com/apache/arrow-adbc/pull/3241#discussion_r2264160275
##########
csharp/src/Drivers/Apache/Hive2/HiveServer2Statement.cs:
##########
@@ -142,7 +146,8 @@ private async Task<QueryResult>
ExecuteQueryAsyncInternal(CancellationToken canc
metadata = await
HiveServer2Connection.GetResultSetMetadataAsync(OperationHandle!,
Connection.Client, cancellationToken);
}
Schema schema = GetSchemaFromMetadata(metadata);
- return new QueryResult(-1, Connection.NewReader(this, schema,
metadata));
+ _currentQueryResult = new QueryResult(-1,
Connection.NewReader(this, schema, metadata));
Review Comment:
My understanding was that we don't expect ExecuteQueryAsync to be called
more than once per statement, I'll let others correct me @jackyhu-db
Edit: nevermind, I guess that's not true?
https://github.com/apache/arrow-adbc/blob/main/c/include/arrow-adbc/adbc.h#L909
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
