toddmeng-db commented on code in PR #3241:
URL: https://github.com/apache/arrow-adbc/pull/3241#discussion_r2264122511
##########
csharp/src/Drivers/Apache/Hive2/HiveServer2Statement.cs:
##########
@@ -142,7 +146,8 @@ private async Task<QueryResult>
ExecuteQueryAsyncInternal(CancellationToken canc
metadata = await
HiveServer2Connection.GetResultSetMetadataAsync(OperationHandle!,
Connection.Client, cancellationToken);
}
Schema schema = GetSchemaFromMetadata(metadata);
- return new QueryResult(-1, Connection.NewReader(this, schema,
metadata));
+ _currentQueryResult = new QueryResult(-1,
Connection.NewReader(this, schema, metadata));
Review Comment:
Thanks for reviewing - when statement is disposed, the stream will most
likely not work anyways. Right now this happens explicitly via
HiveServer2Statement.Dispose() setting OperationHandle = null, but we also send
CloseOperation on Statement disposal. So DatabricksReader and
CloudFetchResultFetcher would stop being able to consume valid results. I'm
guessing that this behavior is reasonable, something we want to keep?
##########
csharp/src/Drivers/Apache/Hive2/HiveServer2Statement.cs:
##########
@@ -142,7 +146,8 @@ private async Task<QueryResult>
ExecuteQueryAsyncInternal(CancellationToken canc
metadata = await
HiveServer2Connection.GetResultSetMetadataAsync(OperationHandle!,
Connection.Client, cancellationToken);
}
Schema schema = GetSchemaFromMetadata(metadata);
- return new QueryResult(-1, Connection.NewReader(this, schema,
metadata));
+ _currentQueryResult = new QueryResult(-1,
Connection.NewReader(this, schema, metadata));
Review Comment:
Thanks for reviewing - when statement is disposed, the stream will most
likely not work anyways. Right now this happens explicitly via
HiveServer2Statement.Dispose() setting OperationHandle = null, but we also send
CloseOperation on Statement disposal.
So DatabricksReader and CloudFetchResultFetcher would stop being able to
consume valid results. I'm guessing that this behavior is reasonable, something
we want to keep?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
