Weijun-H commented on code in PR #8089:
URL: https://github.com/apache/arrow-rs/pull/8089#discussion_r2264921388
##########
parquet-variant-compute/src/cast_to_variant.rs:
##########
@@ -441,6 +474,138 @@ mod tests {
)
}
+ #[test]
+ fn test_cast_to_variant_utf8() {
+ // Test with short strings (should become ShortString variants)
+ let short_strings = vec![
+ Some("hello"),
+ Some(""),
+ None,
+ Some("world"),
+ Some("test"),
+ ];
+ let mut string_builder = StringBuilder::new();
+ for s in short_strings.iter() {
+ match s {
+ Some(value) => string_builder.append_value(value),
+ None => string_builder.append_null(),
+ }
+ }
+ let string_array = string_builder.finish();
+
+ run_test(
+ Arc::new(string_array),
Review Comment:
why not using `StringArray::from`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
